Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexGenerator python script now generate html for Apache fancy directory #159

Merged
merged 9 commits into from
Apr 16, 2020

Conversation

olblak
Copy link
Member

@olblak olblak commented Apr 15, 2020

In the first attempt, the python script only generated a list of packages based on local packages which work for the testing environment but in the case where we already have plenty of packages on pkg.jenkins.io, in this case we would upload two files HEADER.html and FOOTER.html to the remote repository directory

If the apache configuration contains at least the following configuration, it inject some html code before (HEADER.html) and after (FOOTER.html) the directory listing

Documentation

DocumentRoot "/usr/local/apache2/htdocs"
<Directory "/usr/local/apache2/htdocs">
    Options Indexes FollowSymLinks
    AllowOverride FileInfo
    Require all granted

    IndexOptions FancyIndexing VersionSort TrackModified FoldersFirst SuppressHTMLPreamble NameWidth=* SuppressRules SuppressIcon SuppressDescription

    HeaderName HEADER.html
    ReadmeName FOOTER.html

    IndexIgnore HEADER* FOOTER* index.html

</Directory>

Remark: Css work is just a proof of concept, but I leave it to another contribution

Debian screenshot

image

@olblak olblak requested review from timja, oleg-nenashev and slide April 15, 2020 20:04
@timja
Copy link
Member

timja commented Apr 15, 2020

What's the easiest way to test this locally?

@olblak
Copy link
Member Author

olblak commented Apr 16, 2020

What's the easiest way to test this locally?

I added the docker-compose file that I used to test this so first you need to generate debian,redhat,etc packages. or you could mock them just mkdir -p target/debian/ && touch target/debian/jenkins.deb then you can generate the html files ./bin/indexGenerator.py -d debian -o target/debian and finally curl http://localhost/debian

* root file uses base
* fix spacing
* fix product name
* small tweaks
@timja
Copy link
Member

timja commented Apr 16, 2020

What's the easiest way to test this locally?

I added the docker-compose file that I used to test this so first you need to generate debian,redhat,etc packages. or you could mock them just mkdir -p target/debian/ && touch target/debian/jenkins.deb then you can generate the html files ./bin/indexGenerator.py -d debian -o target/debian and finally curl http://localhost/debian

Thanks I used that for testing

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to fix the rendering I wasn't happy with, I've checked all the distributions,

only question is do we want the signing key block to be there on the windows and MSI pages? there's no information on how or if users should verify the signature, I assume windows handles it out of the box so its probably useless there, and not sure about the war one?

@olblak
Copy link
Member Author

olblak commented Apr 16, 2020

I pushed a commit to fix the rendering I wasn't happy with, I've checked all the distributions,

only question is do we want the signing key block to be there on the windows and MSI pages? there's no information on how or if users should verify the signature, I assume windows handles it out of the box so its probably useless there, and not sure about the war one?

Just lack of time but I think it would be usefule to have instruction about verifying certificate, gpg k signature and sha256 if one is available like MSI

@olblak olblak merged commit ff5d792 into jenkinsci:INFRA-910-core-release-automation Apr 16, 2020
@slide
Copy link
Member

slide commented Apr 16, 2020

I pushed a commit to fix the rendering I wasn't happy with, I've checked all the distributions,
only question is do we want the signing key block to be there on the windows and MSI pages? there's no information on how or if users should verify the signature, I assume windows handles it out of the box so its probably useless there, and not sure about the war one?

Just lack of time but I think it would be usefule to have instruction about verifying certificate, gpg k signature and sha256 if one is available like MSI

Windows will automatically verify the signature of the MSI when installing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants