Add support of MSI packaging in Linux #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Apr 3, 2020
olblak
reviewed
Apr 3, 2020
env/test.mk
Outdated
| @@ -25,6 +25,7 @@ export RPM_WEBDIR=/packages/web/redhat${RELEASELINE} | |||
| export SUSE_WEBDIR=/packages/web/opensuse${RELEASELINE} | |||
| export DEB_WEBDIR=/packages/web/debian${RELEASELINE} | |||
| export WAR_WEBDIR=/packages/web/war${RELEASELINE} | |||
| export MSI_WEBDIR=/packages/web/windows${RELEASELINE} | |||
There was a problem hiding this comment.
This variables won't work as it doesn't represent pkg.jenkins.io, this has been correclty updated
https://github.com/jenkinsci/packaging/pull/136/files#diff-4f05c94ba370ba4591cc5eed8b30e0ba
olblak
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuses the WAR publishing codebase to publish MSIs in the same style.
jenkins-infra/release#37 for Pipeline patches.
Untested