Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68890] update test harness to prevent org.xml.sax is accessible from more than one module compile error #6738

Closed
wants to merge 1 commit into from

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Jul 1, 2022

See JENKINS-68890.

downstream of jenkinsci/jenkins-test-harness#449 and jenkinsci/jenkins-test-harness-htmlunit#70

Alternative to #6722

Proposed changelog entries

  • [JENKINS-68890] update test harness to prevent org.xml.sax is accessible from more than one module compile error

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@jtnord jtnord added the developer Changes which impact plugin developers label Jul 1, 2022
@jtnord jtnord closed this Jul 1, 2022
@jtnord jtnord reopened this Jul 1, 2022
@jtnord jtnord changed the title [JENKINS-68890] pick up test harness to use the xml api provided by the JDK [JENKINS-68890] update test harness to prevent org.xml.sax is accessible from more than one module compile error Jul 1, 2022
@jtnord jtnord changed the title [JENKINS-68890] update test harness to prevent org.xml.sax is accessible from more than one module compile error [JENKINS-68890] update test harness to prevent org.xml.sax is accessible from more than one module compile error Jul 1, 2022
@jtnord jtnord marked this pull request as ready for review July 1, 2022 15:31
@NotMyFault NotMyFault added dependencies Pull requests that update a dependency file alternative This PR is one of several options to address a given issue labels Jul 1, 2022
@NotMyFault
Copy link
Member

I'm definitely in favor of the upstream approach over #6722.

@basil
Copy link
Member

basil commented Jul 5, 2022

Closing in favor of #6775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alternative This PR is one of several options to address a given issue dependencies Pull requests that update a dependency file developer Changes which impact plugin developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants