[FIXED JENKINS-39604] - ResourceBundleUtil#getBundle() should report misses on the low level

[oleg-nenashev]

Follow-up to the discussion in #2586 . This resource miss is a common and valid case for missing localizations, hence I propose to use the FINER level.

https://issues.jenkins-ci.org/browse/JENKINS-39604

@reviewbybees @scherler @olivergondza @daniel-beck

[daniel-beck]

Did we confirm, or are we certain, that this happens as regularly as I feared in the other PR?

If so, 👍

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[olivergondza]

@daniel-beck, I interpret it the same way. I expect authors would have an explicit reason to log something as high as WARNING but this seems like a simple mistake.

[scherler]

🐝 Thanks @oleg-nenashev to follow up on that.

[oleg-nenashev]

Did we confirm, or are we certain, that this happens as regularly as I feared in the other PR?

I think we're certain about it, but without jenkinsci/blueocean-plugin#556 we cannot reproduce it, I'd guess. Maybe @scherler could elaborate it

[oleg-nenashev]

@reviewbybees done

[scherler]

@oleg-nenashev @daniel-beck in the original PR @tfennelly stated on the loop that it will be cached, so we only request it once.

that is because of https://github.com/scherler/jenkins/blob/46b483ed190fef1ac39f5e9624706faa20b8c1e4/core/src/main/java/jenkins/util/ResourceBundleUtil.java#L74-L78 and https://github.com/scherler/jenkins/blob/46b483ed190fef1ac39f5e9624706faa20b8c1e4/core/src/main/java/jenkins/util/ResourceBundleUtil.java#L50

Further in https://docs.oracle.com/javase/6/docs/api/java/util/ResourceBundle.html you will find

Cache Management

Resource bundle instances created by the getBundle factory methods are cached by default, and the factory methods return the same resource bundle instance multiple times if it has been cached. getBundle clients may clear the cache, manage the lifetime of cached resource bundle instances using time-to-live values, or specify not to cache resource bundle instances. Refer to the descriptions of the getBundle factory method, clearCache, ResourceBundle.Control.getTimeToLive, and ResourceBundle.Control.needsReload for details.

[jglick]

If and when getBundle returns a non-null value then that is indeed cached. But the case here is that getBundle returns null.

[scherler]

yeah, right. What would you recommend to overcome the later? One idea would be to store all installed plugins scan them and denote which matched and which not, to then only scan newly installed ones, but the question is: is it worth it?

[i386]

Great to see this land 🎉