-
Notifications
You must be signed in to change notification settings - Fork 179
Conversation
pom.xml
Outdated
<dependency> | ||
<groupId>org.slf4j</groupId> | ||
<artifactId>slf4j-api</artifactId> | ||
<version>1.7.30</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not be set here either - this is provided by jenkins and likely an older version.
if you use the version from the bom (set by the parent) at least your tests will blow up as oppsoed to tests passing then the plugin blowing up at runtime.
Whilst the plugin is using the pluginFirstClassloader
the slf4j implementation coming from core will be a different (and older version) likely causing issues (if this is bundled, and if not - best not pretent that you have a version different to what you get)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like the same logic would be applied to the guava
dependency I had to add as well. The tests were failing because of the guice
bump and I could only get it to pass by bumping guava (to at least 25.1-android
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so guava
is probably a bit different as it is not split to an api
and implementation
like slf4j
is .
potentially caused a regression due to updated bundled Guice? |
If you are using |
See https://issues.jenkins.io/browse/JENKINS-65757 for another report of a regression due to updated bundled Guice. |
see #151 for the fix |
Maven version 3.8.1 has some important security fixes that should be rolled into this plugin.
ping @centic9