Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract dep on jjwt-api plugin #366

Merged
merged 4 commits into from
Jan 8, 2021
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 6, 2021

Extracts the dep added in #269 to its own plugin.

Subsumes #365.

@jglick jglick requested a review from bitwiseman January 6, 2021 04:14
pom.xml Outdated
<artifactId>jjwt-jackson</artifactId>
<version>${jjwt.version}</version>
<scope>runtime</scope>
<version>0.11.2-999999-SNAPSHOT</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick
Copy link
Member Author

jglick commented Jan 6, 2021

@jglick
Copy link
Member Author

jglick commented Jan 6, 2021

Did an interactive sanity check in java -jar mode (not hpi:run) to make sure there are no class loading issues. Was able to define App credentials and use them to scan an org.

@jglick jglick marked this pull request as ready for review January 6, 2021 20:24
<artifactId>jjwt-jackson</artifactId>
<version>${jjwt.version}</version>
<scope>runtime</scope>
<version>0.11.2-3.3ae26ccdac4e</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick
So, this is the final released version? Just double checking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! See JEP-229.

@bitwiseman bitwiseman merged commit 8abbb8f into jenkinsci:master Jan 8, 2021
@jglick jglick deleted the jjwt-api branch January 8, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants