refactor: Do not rely on prototype.js

[rahulsom]

Jenkins has been using a very old version of Prototype.js. Starting with 2.406 of Jenkins, prototype is being gradually removed.

This change removes direct calls to prototype in the git-parameter plugin.

Refs: JENKINS-71298

Testing done

I've got another PR open (#97) that verifies the UI still works.
I ran the find command suggested in the ticket - and it only shows a call to jQuery left after this.

Submitter checklist

Preview Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[basil]

Many thanks for removing usages of Prototype from this plugin.

[basil]

The Prototype migration is incomplete. For example, when running with the user experimental flag to disable Prototype, I see console log errors like this:

TypeError: $ is not a function
    gitParameterUpdateSelect http://127.0.0.1/adjuncts/89a94610/net/uaznia/lukanus/hudson/plugins/gitparameter/javascript/git-parameter-select.js:7
    <anonymous> http://127.0.0.1/adjuncts/89a94610/net/uaznia/lukanus/hudson/plugins/gitparameter/javascript/git-parameter-select.js:109
    h http://127.0.0.1/static/89a94610/scripts/hudson-behavior.js:1937
    refillOnChange http://127.0.0.1/static/89a94610/scripts/hudson-behavior.js:1961
    <anonymous> http://127.0.0.1/adjuncts/89a94610/net/uaznia/lukanus/hudson/plugins/gitparameter/javascript/git-parameter-select.js:107
    applySubtree http://127.0.0.1/static/89a94610/scripts/behavior.js:135
    applySubtree http://127.0.0.1/static/89a94610/scripts/behavior.js:126
    applySubtree http://127.0.0.1/static/89a94610/scripts/behavior.js:107
    apply http://127.0.0.1/static/89a94610/scripts/behavior.js:90
    start http://127.0.0.1/static/89a94610/scripts/behavior.js:85
    onload http://127.0.0.1/static/89a94610/scripts/behavior.js:152
    onload http://127.0.0.1/static/89a94610/scripts/behavior.js:152
    addLoadEvent http://127.0.0.1/static/89a94610/scripts/behavior.js:151
    createSearchBox http://127.0.0.1/static/89a94610/scripts/hudson-behavior.js:2420
    <anonymous> http://127.0.0.1/adjuncts/89a94610/jenkins/views/JenkinsHeader/search-box.js:4
    <anonymous> http://127.0.0.1/adjuncts/89a94610/jenkins/views/JenkinsHeader/search-box.js:6

[rahulsom]

Taking this back to draft so I can fix that problem. I'm looking at a few other things - should be back to this shortly.

[rahulsom]

@basil Do you have ideas about how we could get the default user to have that flag?

[basil]

UserExperimentalFlagsPropertyTest in core shows an example of how to run a test as a particular user with a particular flag set. However, RemovePrototypeUserExperimentalFlag isn't available until 2.404, which hasn't released LTS yet.

[basil]

Very nice so far! Just three more points and I should be ready to approve this.

[basil]

Nice job! All the changes from jenkinsci/jenkins#7982 appear to be ported correctly and interactive testing on 2.412 shows no regression in both the success and failure code paths.

[basil]

CC @jenkinsci/core-security-review

[basil]

Released in 0.9.19.