-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-73658 Support regex for tag filter #130
base: master
Are you sure you want to change the base?
Conversation
Let me know if you have any feedback or would like this implemented differently. Thanks! |
@jenkinsadmin @MarkEWaite sorry for the direct ping, this PR has been open for a few months now and I'm hoping to get a review. My team relies on this modification and it would be great to get it into the plugin repository to simplify upgrades to our jenkins instance. Thanks! |
Looks like a Windows test is failing after I synced my branch with master, possibly due to an Azure outage I see on the jenkinsci jenkins? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would very much like to have one or more tests that confirm the added functionality is working as expected. I'd also like to have additional text added to the README file that describes the added functionality.
@@ -1,6 +1,7 @@ | |||
<div> | |||
This parameter is used to get tag from git.<br/> | |||
If is blank, parameter is set to "*".<br/> | |||
Regex patterns must be prefixed with with a forward slash (ie /.*).<br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove duplicated word
Regex patterns must be prefixed with with a forward slash (ie /.*).<br/> | |
Regex patterns must be prefixed with a forward slash (ie /.*).<br/> |
This PR adds logic to allow for a regex filter to be used for the tagFilter. The changes include:
Testing done
In a local instance of Jenkins, installed the plugin and ensured the following patterns functioned as desired:
Submitter checklist