[JENKINS-74019] Extract inline script block from `GitParameterDefinit…

…ion/index.jelly` (#133)
jenkinsci · Oct 31, 2024 · 0d8809b · 0d8809b
1 parent 042a4fa
commit 0d8809b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/...sources/net/uaznia/lukanus/hudson/plugins/gitparameter/GitParameterDefinition/index.jelly b/...sources/net/uaznia/lukanus/hudson/plugins/gitparameter/GitParameterDefinition/index.jelly
@@ -8,7 +8,7 @@
     <j:set var="divId" value="${it.divUUID}" scope="parent"/>
     <j:set var="escapeEntryTitleAndDescription" value="false"/>
     <f:entry title="${h.escape(it.name)}" description="${it.formattedDescription}">
-        <div name="parameter" id="${divId}" data-default-value="${it.defaultValue}" data-selected-value="${it.selectedValue}">
+        <div name="parameter" class="git-parameter-container" id="${divId}" data-default-value="${it.defaultValue}" data-selected-value="${it.selectedValue}">
             <st:adjunct includes="lib.form.select.select"/>
             <input type="hidden" name="name" value="${it.name}"/>
             <select name="value" class="gitParameterSelect" size="${it.listSize}" style="min-width: 200px; font-family: monospace;" id="gitParameterSelect"
@@ -19,10 +19,6 @@
                 <input class='git_parameter_quick_filter' type='text' value='' name='quickFilter' placeholder='Filter'
                        style="vertical-align: top" id="filter"/>
             </j:if>
-            <script type="text/javascript">
-                var parentDiv = jQuery('#${divId}');
-                new GitParameter.QuickFilter(parentDiv);
-            </script>
         </div>
         <j:if test="${it.parameterType eq 'PT_REVISION' and it.descriptor.showNeedToCloneInformation}">
             <div id="git_parameter_info_${divId}">${%needs.to.clone}</div>

diff --git a/...main/resources/net/uaznia/lukanus/hudson/plugins/gitparameter/javascript/git-parameter.js b/...main/resources/net/uaznia/lukanus/hudson/plugins/gitparameter/javascript/git-parameter.js
@@ -153,3 +153,9 @@ var GitParameter = GitParameter || (function($) {
     instance.QuickFilter = QuickFilter;
     return instance;
 })(jQuery);
+
+window.addEventListener('DOMContentLoaded', function() {
+    document.querySelectorAll('.git-parameter-container').forEach(function(container) {
+        new GitParameter.QuickFilter(jQuery(container));
+    });
+});