JENKINS-71655: Add support for AMIs without instance metadata support #874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After https://issues.jenkins.io/browse/JENKINS-65127 was introduced with #609, AMIs without Instance Metadata support were broken. When they were provisioned, they wouldn't get key pairs properly installed by AWS EC2 (the init script on the AMIs would get stuck on waiting to access instance-metadata).
This change introduces a new option to indicate if an AMI does not support instance metadata and thus no
InstanceMetadataOptionsRequest
will be included in the EC2 request to provision an instance.Testing done
mvn test
to make sure no other tests were broken.mvn hpi:run
to make sure the UI showed the new option for metadata supported.Submitter checklist