Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ZpoolMonitor and ZPoolExpandNotice #1030

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jan 6, 2025

This plugin contains an administrative monitor to check if the Jenkins home is running in EC2 on ZFS and report a message if the zpool is running out of space. It is unclear why this functionality lives in the EC2 plugin, as it is not cloud-specific. Moreover, it is probably used by very, very few people, since the relevant libzfs integration hasn't been updated in 7 years, during which I imagine most people running illumos or Solaris on EC2 have since moved to Linux. If anyone truly misses this functionality, it could be moved to Jenkins core and adapted to run regular zfs or zpool commands rather than using a complex Java/C binding, but in the meantime it seems fine to just delete this code and slim down the JPI file of the EC2 plugin to avoid an unnecessary library.

Testing done

mvn clean verify -Dtest=InjectedTest

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@basil basil added the removed label Jan 6, 2025
@basil basil requested a review from a team January 6, 2025 19:31
@res0nance res0nance merged commit e8aedb7 into jenkinsci:master Jan 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants