Remove ZpoolMonitor
and ZPoolExpandNotice
#1030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin contains an administrative monitor to check if the Jenkins home is running in EC2 on ZFS and report a message if the zpool is running out of space. It is unclear why this functionality lives in the EC2 plugin, as it is not cloud-specific. Moreover, it is probably used by very, very few people, since the relevant
libzfs
integration hasn't been updated in 7 years, during which I imagine most people running illumos or Solaris on EC2 have since moved to Linux. If anyone truly misses this functionality, it could be moved to Jenkins core and adapted to run regularzfs
orzpool
commands rather than using a complex Java/C binding, but in the meantime it seems fine to just delete this code and slim down the JPI file of the EC2 plugin to avoid an unnecessary library.Testing done
mvn clean verify -Dtest=InjectedTest
Submitter checklist