-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(updatecli): Adds documentation to the script and enhances the jq
command.
#914
Conversation
jq
command.jq
command.
jq
command.jq
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks says:
✔ Bump UBI9 version:
Source:
✔ [latestVersion] Get the latest UBI9 Linux version
Condition:
✔ [checkUbi9DockerImage] Check if the container image "ubi9" is available
Target:
✔ [updateDockerBake] Update the default value of the variable UBI9_TAG in the docker-bake.hcl
✔ [updateDockerfile] Update the value of the base image (ARG UBI9_TAG) in the Dockerfile
That looks good to me!
Let's have a secondary review by @lemeurherve as he asked for some of these changes in previous PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up!
Some suggestions below.
Thanks for the review! Co-authored-by: lemeurherveCB <[email protected]>
Reposting a comment from an automatically hidden thread:
remark(not concerning this PR): a doc for RedHat API? If so, I don't think it has a place in this repo as it's not a core part of Jenkins agents, I would suggest not spending time on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Co-authored-by: lemeurherveCB <[email protected]>
This is a follow-up PR to #907.
I refined the tag selection logic in
jq
by implementing a filter for tags containing hyphens.To enhance code understanding, I added explanatory comments that provide additional context about the data retrieved from the RedHat REST API.
A comprehensive markdown documentation detailing the API's functionality is currently in development and will be included in an upcoming pull request.
Testing done
Submitter checklist