[JENKINS-62904] Remove unused files #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These views are unused and probably broken after the core tables-to-divs migration.
jglick
approved these changes
Nov 9, 2020
jvz
approved these changes
Nov 9, 2020
Wadeck
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
In the commit Towards 2.0, we can see it was used in SystemCredentialsProvider/index.jelly but the behavior was changed to have something inline instead of the internal tag. Also it was used until 2.0.1 in UserCredentialsProvider#UserCredentialsProperty/config.jelly.
Finally I checked the commit introducing the domainCredential.jelly, and confirm the two usages above were the only one introduced at that time.
I searched in the ecosystems (OSS + CB): no usage of domainCredential.
ℹ️ FTR the files in src/main/webapp/help/domain/ are still used, e.g. by CredentialsStoreAction#DomainWrapper.configure.jelly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are unused and probably broken after the core tables-to-divs migration.
I've searched through the Jenkins ecosystem and haven't found any usages. This looks like something that was started at some point, but never completed, perhaps during the 1.0 to 2.0 transition of credentials-plugin. This doesn't show up in the credentials plugin UI nor is it referenced anywhere else.
After the tables-to-divs migration in Jenkins core, the domainCredential.jelly file probably doesn't work correctly. Instead of removing it, fixing it would require making sure it works correctly before the change and then testing to ensure it has been corrected.
See JENKINS-62904.