Apply some code modernization for Java 8 and recent Jenkins #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates code to use currently supported language features. Signed-off-by: Matt Sicker <[email protected]>
jglick
approved these changes
Apr 20, 2020
src/main/java/com/cloudbees/plugins/credentials/CredentialsProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/plugins/credentials/CredentialsProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/plugins/credentials/CredentialsProvider.java
Outdated
Show resolved
Hide resolved
| iterator.remove(); | ||
| } | ||
| } | ||
| resolverByName.values().removeIf(r -> r == ContextResolver.NONE); |
| iterator.remove(); | ||
| } | ||
| } | ||
| providerByName.values().removeIf(p -> p == CredentialsProvider.NONE); |
src/main/java/com/cloudbees/plugins/credentials/CredentialsStore.java
Outdated
Show resolved
Hide resolved
| iterator.remove(); | ||
| } | ||
| } | ||
| requirements.removeIf(r -> r instanceof HostnamePortRequirement); |
There was a problem hiding this comment.
(Reviewer note: these cases are deliberately mutating, it seems.)
| @@ -285,7 +285,7 @@ public void testNodeCredentialFingerprintsAreRemovedForNonExistentNodes() throws | |||
| DumbSlave addedSlave = new DumbSlave("added-slave", | |||
| "dummy", "/home/test/slave", "1", Node.Mode.NORMAL, "remote", | |||
| new JNLPLauncher(), | |||
| RetentionStrategy.INSTANCE, Collections.<NodeProperty<?>>emptyList()); | |||
| RetentionStrategy.INSTANCE, Collections.emptyList()); | |||
There was a problem hiding this comment.
FYI, this constructor is deprecated and you can more easily use a simpler version.
Signed-off-by: Matt Sicker <[email protected]>
Signed-off-by: Matt Sicker <[email protected]>
Signed-off-by: Matt Sicker <[email protected]>
Signed-off-by: Matt Sicker <[email protected]>
jvz
changed the title
Signed-off-by: Matt Sicker <[email protected]>
Signed-off-by: Matt Sicker <[email protected]>
Signed-off-by: Matt Sicker <[email protected]>
Signed-off-by: Matt Sicker <[email protected]>
res0nance
approved these changes
Apr 21, 2020
| @@ -178,7 +178,7 @@ public CredentialsStore getStore(@CheckForNull ModelObject object) { | |||
| } | |||
| } | |||
| } | |||
| return new ArrayList<C>(); | |||
| return new ArrayList<>(); | |||
There was a problem hiding this comment.
Suggested change
| return new ArrayList<>(); | |
| return Collections.emptyList(); |
…sProvider.java Co-Authored-By: Raihaan Shouhell <[email protected]>
|
GitHub outage caused build failure. Closing to retry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates code to use currently supported language features.
Signed-off-by: Matt Sicker [email protected]