Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit sed replacement to line 17 #749

Merged
merged 5 commits into from
Dec 3, 2021
Merged

limit sed replacement to line 17 #749

merged 5 commits into from
Dec 3, 2021

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Dec 3, 2021 •
edited by jglick
Loading

the property is not likely to change line number.

Avoid this from repeating: a89f401 (#746)

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja merged commit 8cb21be into jenkinsci:master Dec 3, 2021
@jetersen jetersen deleted the fix/sedToSpecificLine branch December 3, 2021 08:59
@jglick jglick added the chore Reduces future maintenance label Dec 3, 2021
@jglick
Copy link
Member

jglick commented Dec 3, 2021

BTW jenkins-infra/interesting-category-action#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
chore Reduces future maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jetersen @jglick @timja