Hack to test JENKINS-45047 #1059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
force-pushed
the
JENKINS-45047
branch
6 times, most recently
from
69780d8 to
13506aa
Compare
basil
force-pushed
the
JENKINS-45047
branch
16 times, most recently
from
34e2469 to
0f9538e
Compare
basil
force-pushed
the
JENKINS-45047
branch
4 times, most recently
from
fca3856 to
3ad520a
Compare
basil
force-pushed
the
JENKINS-45047
branch
2 times, most recently
from
7ed8c53 to
15ba998
Compare
jglick
reviewed
Jul 20, 2022
prep.sh
Outdated
| @@ -41,7 +41,7 @@ for LINE in $LINEZ; do | |||
| done | |||
|
|
|||
| # TODO find a way to encode this in some POM so that it can be managed by Dependabot | |||
| version=1152.vafc19b26d5aa # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/345 | |||
| version=1167.vc04b718e32d4 # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/360 | |||
There was a problem hiding this comment.
basil
force-pushed
the
JENKINS-45047
branch
14 times, most recently
from
c22c98d to
9bfdddd
Compare
jetersen
reviewed
Jul 26, 2022
prep.sh
Outdated
| @@ -41,7 +41,7 @@ for LINE in $LINEZ; do | |||
| done | |||
|
|
|||
| # TODO find a way to encode this in some POM so that it can be managed by Dependabot | |||
| version=1152.vafc19b26d5aa # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/345 | |||
| version=1175.vb05220ee3c55 # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/375 | |||
There was a problem hiding this comment.
Suggested change
| version=1175.vb05220ee3c55 # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/375 | |
| version=1178.vbef3c43d0e69 |
There was a problem hiding this comment.
Yeah, hopefully this is the latest round of testing I need to do on this PR. Now comes the hard part: writing the PR description for my non-draft PR. I always think that writing the code is easy compared to writing the PR description.
There was a problem hiding this comment.
@basil PR description suggestion: Make shit work with proper testing and more correct hackz
…rmPom` to HPI plugin `overrideWar`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not review. Filing this PR only to kick the tires on jenkinsci/maven-hpi-plugin#66 on some real use cases.