Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support high intensity ANSI colors #16 with jansi-1.12 #72

Merged
merged 3 commits into from
May 31, 2016
Merged

Support high intensity ANSI colors #16 with jansi-1.12 #72

merged 3 commits into from
May 31, 2016

Conversation

marlene01
Copy link
Contributor

pom.xml changes: - increased dependency of jansi to 1.12
- fixed the pom error with animal-sniffer plugin
AnsiHtmlOutputStream changes:

  • added method processSetForegroundColor with additional parameter boolean bright to handle the 90 to 97 colors.

@marlene01
Support high intensity ANSI colors jenkinsci#16 with jansi-1.12
afeab45 
pom.xml changes: - increased dependency of jansi to 1.12
                 - fixed the pom error with animal-sniffer plugin
AnsiHtmlOutputStream changes:
 - added method processSetForegroundColor with additional parameter boolean bright to handle the 90 to 97 colors.
@marlene01 marlene01 force-pushed the 16_high_intensity_ansi_colors branch from 0f62e6c to afeab45 Compare May 30, 2016 11:40
@marlene01 marlene01 mentioned this pull request May 30, 2016
Closed
@dblock
Copy link
Member

dblock commented May 30, 2016

There're a lot of spaces -> tabs changes here, can you please fix that? Otherwise we have huge diffs and can't figure out what's going on.

dblock
dblock reviewed May 30, 2016
View reviewed changes
CHANGELOG.md
@@ -2,6 +2,7 @@ Next Release
============

* Your contribution here.
* [#72](https://github.com/dblock/jenkins-ansicolor-plugin/pull/72): Support high intensity ansi colors - [@marlene01](https://github.com/marlene01).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ansi => ANSI

@dblock
Copy link
Member

dblock commented May 30, 2016

This needs tests, please, at least around processSetForegroundColor functionality.

marlene01 added 2 commits May 31, 2016 09:49
@marlene01
Added Test testSetForegroundColorToHighIntensity to AnsiHtmlOutputStr…
9067afb 
…eamTest.java

CHANGELOG.md ansi -> ANSI
Removed tabs from AnsiHtmlOutputStreamTest.java
@marlene01
Fixed the tabs and spaces problem.
7350e7e
@marlene01
Copy link
Contributor Author

I fixed the issues in a new branch called 16_high_intensity_ansi_colors_one_commit which can be found here:
https://github.com/marlene01/jenkins-ansicolor-plugin/tree/16_high_intensity_ansi_colors_one_commit

@dblock dblock merged commit d3e796f into jenkinsci:master May 31, 2016
@dblock
Copy link
Member

dblock commented May 31, 2016

Merged, thank you! We should do a release soon.

@marlene01
Copy link
Contributor Author

Great! :-)
But what about the dependency in jenkins-core to jansi 1.9?
Should I create a Issue on the https://issues.jenkins-ci.org/browse/JENKINS-35254?jql=project%20%3D%20JENKINS board?

@dblock
Copy link
Member

dblock commented Jun 1, 2016

Definitely @marlene01, at the very least Jenkins future versions should upgrade Jansi.

@dblock
Copy link
Member

dblock commented Nov 21, 2016

This was finally released in 0.4.3. Thanks for your patience.

This was referenced Mar 3, 2017
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marlene01 @dblock