-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#375] Allow cross-account AWS IAM role assumption into opt-in regions #376
base: master
Are you sure you want to change the base?
[#375] Allow cross-account AWS IAM role assumption into opt-in regions #376
Conversation
… opt-in regions Added authRegion drop-down list-box & variable to allow explicitly stating the region for authenticating with AWS IAM.
return RegionUtils.getRegion(regionName); | ||
} else { | ||
return Region.getRegion(Regions.US_EAST_1); | ||
public ListBoxModel doFillAuthRegionItems() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
return RegionUtils.getRegion(regionName); | ||
} else { | ||
return Region.getRegion(Regions.US_EAST_1); | ||
public ListBoxModel doFillAuthRegionItems() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
return options; | ||
} | ||
|
||
public ListBoxModel doFillRegionNameItems() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
return options; | ||
} | ||
|
||
public ListBoxModel doFillRegionNameItems() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
@@ -507,9 +526,17 @@ | |||
} | |||
return options; | |||
} | |||
|
|||
public ListBoxModel doFillAuthRegionItems() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
@@ -507,9 +526,17 @@ | |||
} | |||
return options; | |||
} | |||
|
|||
public ListBoxModel doFillAuthRegionItems() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
@Stericson appreciate your input here. Many thanks! |
Added authRegion drop-down list-box & variable to allow explicitly stating the region for authenticating with AWS IAM. This will address Issue #375 by permitting authentication with a region that is opted-in in the source AWS account, while accessing ECS clusters in an opt-in region in the target account (which is not opted-in for the source account).
The solution was adding an
authRegion
list-box to choose the region used for IAM authentication, which is stored in anauthRegion
variable. This box works in exactly the same manner as theregionName
variable box, but by separating them it is now possible to authenticate with AWS IAM in region A while using ECS clusters in region B.Testing done by:
Submitter checklist