Avoid excessive Closures
#374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Feb 25, 2025
| CheckoutScript.doCheckout(script, describable, null, body).call() | ||
| } | ||
| public void run(Closure body) { | ||
| try { |
jglick
commented
Feb 25, 2025
| @@ -69,7 +69,7 @@ public class ECSLauncher extends JNLPLauncher { | |||
| private final ECSCloud cloud; | |||
| private final ECSService ecsService; | |||
| private boolean launched; | |||
| private final int maxAttempts = 2; | |||
| private static final int maxAttempts = 2; | |||
jglick
commented
Feb 25, 2025
| @@ -47,7 +47,7 @@ public class ECSTaskTemplateStep extends Step implements Serializable { | |||
| private static final long serialVersionUID = 1L; | |||
| private static final Logger LOGGER = Logger.getLogger(ECSTaskTemplateStep.class.getName()); | |||
|
|
|||
| private final String DEFAULT_CLOUD = "cloud-default"; | |||
| private static final String DEFAULT_CLOUD = "cloud-default"; | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on jenkinsci/pipeline-model-definition-plugin#762. Supersedes #364, #366, and #368. Untested since I did not see any relevant test cases and I presume manual testing would require special setup with an AWS account.