Add docs for library organization best practices #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since I'm pretty much the only active maintainer of this repo these days, I'll merge this PR in one week unless there are any objections. Reviews would be appreciated, though. |
UlrichEckhardt
approved these changes
Apr 12, 2022
nre-ableton
force-pushed
the
nre/master/add-organization-docs
branch
from
105d0ea to
c50e27e
Compare
stchar
reviewed
Apr 18, 2022
|
|
||
| @Test | ||
| void testComplexOperation() { | ||
| int result = new HardMath(script: script).complexOperation(1, 3) |
There was a problem hiding this comment.
new HardMath(..) is awesome. I used to create pipeline script just as EmptyPipeline but to load the library and to return an instance of my library class. But your approach is way way way better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm improving the documentation in the
READMEto add some best-practices regarding library organization. This is based mostly on a recent discussion in another issue, but also because I find myself copy-pasting the same advice to several other issues.