Add support for alwaysPull in docker agent #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current test asserts that `image` is never the first argument. In fact, the order of arguments isn't guaranteed, so we should only assert that `image: someVar` is contained in the stacktrace.
|
@dblock -- I'm adding you as a reviewer because there aren't any other active maintainers these days. Do the changes in this PR look ok to you? |
dblock
approved these changes
Nov 19, 2021
|
@dblock Well, I normally stay away from the declarative stuff, since I don't use the declarative API and am completely unfamiliar with it, but changes like this are pretty easy to make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
alwaysPullattribute ofdockerblocks in declarative pipelines. Fixes #432.