Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support commit context match pattern #1384

Merged

Conversation

dippynark
Copy link
Contributor

@dippynark dippynark commented Nov 10, 2021

If there are multiple CI jobs running against the same repository, poller may think that the Lighthouse job has run, when actually it was another system (e.g. Jenkins). This PR adds support for a flag to supply a regex pattern for matching the commit status context so that poller is looking for signs of the correct job.

@jenkins-x-bot
Copy link
Contributor

Hi @dippynark. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@dippynark
Copy link
Contributor Author

/assign @dgozalo

@dippynark dippynark changed the title feat: Support commit label regex pattern feat: Support commit context match pattern Nov 11, 2021
@rawlingsj
Copy link
Member

/lgtm

@rawlingsj
Copy link
Member

/ok-to-test

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dippynark dippynark force-pushed the support-commit-label-regex-pattern branch from 3e1aa22 to 12ebcb4 Compare November 17, 2021 20:28
@jenkins-x-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants