Params declared in pre/postsubmit config are not passed to LighthouseJobSpec

[chrissena]

It appears that the pipeline_run_params declared in the presubmit/postsubmit config in trigger.yaml are not copied to the generated LighthouseJobSpec and are therefore not available later to the subsequent code that generates the PipelineRun resource.

I had a browse of the source code and it looks like the bug is caused here:

lighthouse/pkg/jobutil/jobutil.go

Lines 160 to 174 in 860dc3b

	func specFromJobBase(jb job.Base) v1alpha1.LighthouseJobSpec {
	var namespace string
	if jb.Namespace != nil {
	namespace = *jb.Namespace
	}
	return v1alpha1.LighthouseJobSpec{
	Agent: jb.Agent,
	Job: jb.Name,
	Namespace: namespace,
	MaxConcurrency: jb.MaxConcurrency,
	PodSpec: jb.Spec,
	PipelineRunSpec: jb.PipelineRunSpec,
	}
	}

as the line PipelineRunParams: jb.PipelineRunParams is missing.

[jenkins-x-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale