Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed repo breaks lighthouse normal function #1116

Closed
apenen opened this issue Oct 16, 2020 · 4 comments · Fixed by #1564
Closed

Renamed repo breaks lighthouse normal function #1116

apenen opened this issue Oct 16, 2020 · 4 comments · Fixed by #1564

Comments

@apenen
Copy link

apenen commented Oct 16, 2020

Hi!

When someone renames a project in git (badly done)... The current PR job has to be deleted or jx cannot continue with the next.

{"component":"keeper","error":"failed to perform REST query for PRs: listing all open pull requests for : 404 Project Not Found","file":"/workspace/source/cmd/keeper/main.go:182","func":"main.sync","level":"error","msg":"Error syncing.","time":"2020-10-16T06:48:28Z"}

Any ideas?

@apenen apenen changed the title Renamed repo breaks jobs Renamed repo breaks lighthouse normal function Oct 16, 2020
@jenkins-x-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

@jenkins-x-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten

@keskad
Copy link

keskad commented Jan 31, 2022

Hi, I have exactly the same issue. I think its pretty critical in my opinion, here is the use case:

  • Non-administrative user deletes or renames his/her own repository from Gitlab/Github
  • Then lighthouse-keeper does not work for ANY project on Jenkins X and nobody knows why

Here are logs (using Gitlab self hosted):

{"component":"keeper","controller":"sync","error":"listing all open pull requests for root/golang-http-test: Not Found","file":"/workspace/source/pkg/keeper/keeper.go:336","func":"github.com/jenkins-x/lighthouse/pkg/keeper.(*DefaultController).Sync","level":"warning","msg":"failed to perform REST query for PRs","time":"2022-01-31T11:41:16Z"}

In my opinion non-administrative user should not be able to impact on other user's work.

Using ghcr.io/jenkins-x/lighthouse-keeper:1.5.7

@keskad
Copy link

keskad commented Jan 31, 2022

/remove-lifecycle rotten

msvticket added a commit that referenced this issue Aug 4, 2023
jenkins-x-bot pushed a commit to jenkins-x/jx3-versions that referenced this issue Aug 4, 2023
from: https://github.com/jenkins-x/lighthouse.git

-----
# jenkins-x/lighthouse

## Changes in version 1.13.3

### Bug Fixes

* skip repo that can't queried (Mårten Svantesson) [#1116](jenkins-x/lighthouse#1116)

### Issues

* [#1116](jenkins-x/lighthouse#1116) Renamed repo breaks lighthouse normal function
JordanGoasdoue pushed a commit to JordanGoasdoue/lighthouse that referenced this issue Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants