-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update _index.md versions #3744
base: main
Are you sure you want to change the base?
Conversation
Hi @clintonsteiner. Thanks for your PR. I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ad900cb
to
3e0d6f6
Compare
3e0d6f6
to
5e824e4
Compare
Per jx repo - go version used is 1.23 and golang ci expected version is 1.50.1 https://github.com/jenkins-x/jx/blob/274bb14e07bada58978129a9754352316a4bf568/hack/linter.sh#L12 https://github.com/jenkins-x/jx/blob/274bb14e07bada58978129a9754352316a4bf568/Dockerfile-go Signed-off-by: CJ Steiner <[email protected]>
5e824e4
to
562fe9f
Compare
|
/ok-to-test |
You haven't changed to the relevant version of golang ci. You can see the relevant versions here: https://github.com/jenkins-x/jx3-pipeline-catalog/blob/master/tasks/go-plugin/pullrequest.yaml |
⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3744 here |
Per jx repo - go version used is 1.23 and golang ci expected version is 1.50.1 https://github.com/jenkins-x/jx/blob/274bb14e07bada58978129a9754352316a4bf568/hack/linter.sh#L12 https://github.com/jenkins-x/jx/blob/274bb14e07bada58978129a9754352316a4bf568/Dockerfile-go
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist: