Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add carlosrodf as developer for amazon-ecs plugin #2011

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

carlosrodf
Copy link
Contributor

Description

Adding myself (@carlosrodf) as a developer for the amazon-ecs plugin as requested here -> jenkinsci/amazon-ecs-plugin#200 (comment)
plugin: https://github.com/jenkinsci/amazon-ecs-plugin

@webratz
@pgarbe
@gokhanoner

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@carlosrodf carlosrodf requested a review from a team as a code owner July 1, 2021 02:06
@carlosrodf carlosrodf closed this Jul 1, 2021
@carlosrodf carlosrodf reopened this Jul 1, 2021
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin is up for adoption already so good to go I believe.

Thanks for stepping up!

@timja timja merged commit 9ed1e24 into jenkins-infra:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants