Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buildPluginWithGradle) Add quality checks #652

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

alextu
Copy link
Contributor

@alextu alextu commented Apr 19, 2023

Related to jenkinsci/gradle-jpi-plugin#213

This adds support for publishing reports like it's done on the Maven side, with the exception of PMD and CPD.
The latest JPI plugin version supports simple configuration of Checkstyle, JaCoCo and SpotBugs. See https://github.com/jenkinsci/gradle-jpi-plugin#enabling-quality-checks

Unit tests are similar to the Maven ones, only the report patterns change.
Manual testing has been done on a local Jenkins instance.

@alextu alextu requested a review from a team April 19, 2023 14:07
@dduportal
Copy link
Contributor

Thanks @alextu ! Do you mind updating the title of the PR to feat(buildPluginWithGradle) Add quality checks to materialize the following:

  • It's a new feature
  • It's scoped to the buildPluginWithGradle function?

Ping @jglick @daniel-beck @MarkEWaite @timja @basil I don't feel legit to review this PR but its goal is clear and seems good, would you have some time to spend on it to help?

@alextu alextu changed the title Add quality checks to buildPluginWithGradle feat(buildPluginWithGradle) Add quality checks Apr 21, 2023
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to where this has been tested?

see
https://github.com/jenkinsci/jenkins-infra-test-plugin/pull/82/files

for an example of testing this repository

@alextu
Copy link
Contributor Author

alextu commented Apr 24, 2023

Link to where this has been tested?

see https://github.com/jenkinsci/jenkins-infra-test-plugin/pull/82/files

for an example of testing this repository

Here's an example: https://ci.jenkins.io/job/Plugins/job/gradle-plugin/job/atual%2Ftest-reports/1/ showing reports (and failing the build)

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timja timja enabled auto-merge (squash) April 26, 2023 14:34
@timja timja merged commit 596661d into jenkins-infra:master Apr 26, 2023
@alextu alextu deleted the atual/exp branch April 26, 2023 16:15
alextu added a commit to alextu/pipeline-library that referenced this pull request May 2, 2023
* origin/master:
  Bump `hashicorp-tools` docker image to 0.5.163 (jenkins-infra#659)
  fix(buildPlugin) ensure the custom label is passed to node when adding custom platform (jenkins-infra#658)
  feat(buildPluginWithGradle) Add quality checks (jenkins-infra#652)
  hotfix(terraform) add spot toleration
  hotfix(terraform) add nodeselector
  Update updatecli version to v0.49.2 (jenkins-infra#657)
  fix(terraform): add toleration to use infracipool (jenkins-infra#655)
  Bump `hashicorp-tools` docker image to 0.5.162 (jenkins-infra#651)
smerle33 pushed a commit to smerle33/pipeline-library that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants