-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(buildPluginWithGradle) Add quality checks #652
Conversation
Thanks @alextu ! Do you mind updating the title of the PR to
Ping @jglick @daniel-beck @MarkEWaite @timja @basil I don't feel legit to review this PR but its goal is clear and seems good, would you have some time to spend on it to help? |
buildPluginWithGradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to where this has been tested?
see
https://github.com/jenkinsci/jenkins-infra-test-plugin/pull/82/files
for an example of testing this repository
Here's an example: https://ci.jenkins.io/job/Plugins/job/gradle-plugin/job/atual%2Ftest-reports/1/ showing reports (and failing the build) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the README is updated https://github.com/jenkins-infra/pipeline-library#buildpluginwithgradle
and the docs file:
https://github.com/jenkins-infra/pipeline-library/blob/master/vars/buildPluginWithGradle.txt
* origin/master: Bump `hashicorp-tools` docker image to 0.5.163 (jenkins-infra#659) fix(buildPlugin) ensure the custom label is passed to node when adding custom platform (jenkins-infra#658) feat(buildPluginWithGradle) Add quality checks (jenkins-infra#652) hotfix(terraform) add spot toleration hotfix(terraform) add nodeselector Update updatecli version to v0.49.2 (jenkins-infra#657) fix(terraform): add toleration to use infracipool (jenkins-infra#655) Bump `hashicorp-tools` docker image to 0.5.162 (jenkins-infra#651)
Related to jenkinsci/gradle-jpi-plugin#213
This adds support for publishing reports like it's done on the Maven side, with the exception of PMD and CPD.
The latest JPI plugin version supports simple configuration of Checkstyle, JaCoCo and SpotBugs. See https://github.com/jenkinsci/gradle-jpi-plugin#enabling-quality-checks
Unit tests are similar to the Maven ones, only the report patterns change.
Manual testing has been done on a local Jenkins instance.