Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get-jenkins-io): allow release.ci.jenkins.io to interact with its storage account #613

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jan 31, 2024

This PR adds release.ci.jenkins.io subnet to getjenkinsio storage account's allowed virtual nets, and adds Storage Account Contributor role assignment to privatek8s's service principal.

Ref:

@lemeurherve lemeurherve requested review from dduportal, smerle33 and a team January 31, 2024 12:30
smerle33
smerle33 previously approved these changes Jan 31, 2024
Copy link
Collaborator

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lemeurherve lemeurherve merged commit 7099211 into jenkins-infra:main Jan 31, 2024
2 checks passed
@lemeurherve lemeurherve deleted the helpdesk3927-add-privatek8s-release-subnet-to-getjenkinsio branch January 31, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants