-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(get.jenkins.io/storage): new premium storage class for get.jenkins.io #598
Merged
dduportal
merged 8 commits into
jenkins-infra:main
from
smerle33:get.jenkins.io/storageclass
Jan 25, 2024
Merged
feat(get.jenkins.io/storage): new premium storage class for get.jenkins.io #598
dduportal
merged 8 commits into
jenkins-infra:main
from
smerle33:get.jenkins.io/storageclass
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
reviewed
Jan 24, 2024
lemeurherve
reviewed
Jan 25, 2024
Co-authored-by: Hervé Le Meur <[email protected]>
dduportal
reviewed
Jan 25, 2024
dduportal
reviewed
Jan 25, 2024
dduportal
reviewed
Jan 25, 2024
dduportal
reviewed
Jan 25, 2024
dduportal
reviewed
Jan 25, 2024
dduportal
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Plan looks good
For info, this PR failed to deploy with the following error:
|
Gotcha! we want |
dduportal
added a commit
that referenced
this pull request
Jan 25, 2024
Ref. jenkins-infra/helpdesk#3917 Fixup of #598 This PR correct attributes, mainly `account_kind` which must have the value `FileStorage` Signed-off-by: Damien Duportal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per jenkins-infra/helpdesk#3917