Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(get.jenkins.io/storage): new premium storage class for get.jenkins.io #598

Merged
merged 8 commits into from
Jan 25, 2024
Merged

feat(get.jenkins.io/storage): new premium storage class for get.jenkins.io #598

merged 8 commits into from
Jan 25, 2024

Conversation

smerle33
Copy link
Collaborator

@smerle33 smerle33 commented Jan 23, 2024

@smerle33 smerle33 changed the title WIP(get.jenkins.io/storage): new premium storage class for get.jenkin… WIP(get.jenkins.io/storage): new premium storage class for get.jenkins.io Jan 23, 2024
@smerle33 smerle33 requested a review from dduportal January 25, 2024 10:51
@dduportal dduportal changed the title WIP(get.jenkins.io/storage): new premium storage class for get.jenkins.io feat(get.jenkins.io/storage): new premium storage class for get.jenkins.io Jan 25, 2024
@dduportal dduportal marked this pull request as ready for review January 25, 2024 14:27
@dduportal dduportal requested a review from a team January 25, 2024 14:27
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Plan looks good

@dduportal dduportal enabled auto-merge (squash) January 25, 2024 14:30
@dduportal dduportal merged commit 4ea3944 into jenkins-infra:main Jan 25, 2024
2 checks passed
@dduportal
Copy link
Contributor

For info, this PR failed to deploy with the following error:

 Error: creating Storage Account (Subscription: "****"
 │ Resource Group Name: "get-jenkins-io"
 │ Storage Account Name: "getjenkinsio"): storage.AccountsClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="LocationNotValid" Message="Supplied location eastus2 is not valid."
 │ 
 │   with azurerm_storage_account.get_jenkins_io,
 │   on get.jenkins.io.tf line 8, in resource "azurerm_storage_account" "get_jenkins_io":
 │    8: resource "azurerm_storage_account" "get_jenkins_io" {

@dduportal
Copy link
Contributor

For info, this PR failed to deploy with the following error:

 Error: creating Storage Account (Subscription: "****"
 │ Resource Group Name: "get-jenkins-io"
 │ Storage Account Name: "getjenkinsio"): storage.AccountsClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="LocationNotValid" Message="Supplied location eastus2 is not valid."
 │ 
 │   with azurerm_storage_account.get_jenkins_io,
 │   on get.jenkins.io.tf line 8, in resource "azurerm_storage_account" "get_jenkins_io":
 │    8: resource "azurerm_storage_account" "get_jenkins_io" {

Gotcha! we want account_kind to be FileStorage (and not StorageV2 by default)

dduportal added a commit that referenced this pull request Jan 25, 2024
Ref. jenkins-infra/helpdesk#3917

Fixup of #598 

This PR correct attributes, mainly `account_kind` which must have the
value `FileStorage`

Signed-off-by: Damien Duportal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants