Add support for del keyword for overridden functions
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 18 18
Lines 635 635
=======================================
Hits 631 631
Misses 4 4
Continue to review full report at Codecov.
|
sshishov
force-pushed
the
ss/add-support-del-keyword
branch
from
e4c388f to
14b7750
Compare
jendrikseipp
requested changes
Apr 22, 2022
sshishov
force-pushed
the
ss/add-support-del-keyword
branch
from
14b7750 to
13951ee
Compare
|
Going to update the README and rebase from latest master. |
sshishov
force-pushed
the
ss/add-support-del-keyword
branch
2 times, most recently
from
cc84e6f to
fb659b0
Compare
sshishov
force-pushed
the
ss/add-support-del-keyword
branch
from
fb659b0 to
4c2ce60
Compare
|
@jendrikseipp I have updated the README file. Could you please check? If you have better wording, please provide here, I will kindly make the changes. |
|
Thanks for the revisions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you override the function of any framework or any library and you are not using all parameters, then the parameters which are not used are identified as
unused. It is good practice while overriding function/method to keep the signature of it intact. Otherwise you can get potentially some issues with next releases etc.Description
Adding support for
deloperation inside the function. The keyworddelwill mark the variable as used now and we can safely implement the suggested workaround.Related Issue
This PR is addressing the issue #278
Checklist:
tox -e fix-styleto format my code and checked the result withtox -e style.