Fuzzing: Build Fuzz Tests with Rust Extensions and Optional Features #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the OSS-Fuzz container environment & build script to build and install Dulwich with all optional features enabled and refines dictionary handling. Impact: - Increases the fuzz-able surface area of the most interesting (from a fuzzing & security testing perspective) Dulwich APIs, enabling future fuzz harnesses improvements to specifically target these features in tests. - Enhances flexibility of fuzzer seed data generation steps to improve dictionary quality and simplify seed corpus management for all fuzz targets. Key Changes in `build.sh`: - Unset problematic OSS-Fuzz provided `$RUSTFLAGS` to prevent build issues that inhibit PyO3 based Rust extension compilation. - Install Python dependencies with specific features (`fastimport`, `gpg`, `paramiko`, etc.). - Added "drop-in" support for inclusion of seed corpora zip files & LibFuzzer options files to be introduced later. Key Changes in `container-environment-bootstrap.sh`: - Installs dependencies required to build Dulwich's optional features and Rust extensions. - Updated Python dependencies (`setuptools`, `pyinstaller`, etc.) to the latest compatible versions. - Improved dictionary handling for fuzz targets by encapsulating dictionary generation logic in shell functions and adding default common dictionary entries to all fuzz target specific `.dict` files.
jelmer
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the OSS-Fuzz container environment & build script to build and install Dulwich with all optional features enabled and refines dictionary handling.
Impact:
Key Changes in
build.sh:$RUSTFLAGSto prevent build issues that inhibit PyO3 based Rust extension compilation.fastimport,gpg,paramiko, etc.).Key Changes in
container-environment-bootstrap.sh:setuptools,pyinstaller, etc.) to the latest compatible versions..dictfiles.