Wrap all urllib3 read ProtocolErrors as GitProtocolError #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanonyme
force-pushed
the
protocolerror
branch
2 times, most recently
from
0fcea15 to
f2f842c
Compare
|
@jelmer not sure if this is overkill. It seemed simpler to just add an exception to protocol.py but that would have leaked HTTP client implementation details there (it looked like this has been insulated into client.py). |
jelmer
requested changes
Mar 13, 2024
|
Looks like CI is failing all over due to ruff |
jelmer
approved these changes
Mar 14, 2024
|
@jelmer Is there any plan for next release? |
|
Not currently but I can probably do one in the next couple of weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1225