Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove safe area padding on video container #6453

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Jan 16, 2025

Changes
Removes the safe area padding from the video container. The controls still have the correct padding, but this allows the video to cover the entire screen.

Before
IMG_7346

After
IMG_7344

Issues
Related to jellyfin/jellyfin-expo#377

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Jan 16, 2025
@thornbill thornbill added this to the v10.10.4 milestone Jan 16, 2025
@thornbill thornbill requested a review from a team as a code owner January 16, 2025 20:37
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Jan 16, 2025

Cloudflare Pages deployment

Latest commit 88cc991
Status ✅ Deployed!
Preview URL https://34fe4228.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@dmitrylyzo
Copy link
Contributor

I think these should be removed as well:

padding-left: env(safe-area-inset-left);
padding-right: env(safe-area-inset-right);
padding-top: env(safe-area-inset-top);
padding-bottom: env(safe-area-inset-bottom);

@thornbill thornbill merged commit 7a07a79 into jellyfin:release-10.10.z Jan 18, 2025
15 checks passed
@thornbill thornbill deleted the fix-player-inset branch January 18, 2025 07:45
thornbill added a commit that referenced this pull request Jan 22, 2025
Remove safe area padding on video container

Original-merge: 7a07a79

Merged-by: thornbill <[email protected]>

Backported-by: thornbill <[email protected]>
@thornbill thornbill removed the stable backport Backport into the next stable release label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants