Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show enabled filters #6286

Merged

Conversation

viown
Copy link
Member

@viown viown commented Nov 1, 2024

If the user filters by tag or genre and items relevant to the filter get removed from the library, the user will not be able to uncheck them from the filter dialog until they clear cache.

Changes
Always show enabled filters to allow the user to remove them

Issues
Fixes #6283

@viown viown requested a review from a team as a code owner November 1, 2024 20:48
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 1, 2024

Cloudflare Pages deployment

Latest commit f49a9ef
Status ✅ Deployed!
Preview URL https://1d84486b.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@viown viown linked an issue Nov 1, 2024 that may be closed by this pull request
@viown viown added the bug Something isn't working label Nov 1, 2024
src/components/filterdialog/filterdialog.js Outdated Show resolved Hide resolved
src/components/filterdialog/filterdialog.js Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 1, 2024

@thornbill thornbill added the stable backport Backport into the next stable release label Nov 1, 2024
@thornbill thornbill merged commit ed3671a into jellyfin:release-10.10.z Nov 1, 2024
14 checks passed
@thornbill thornbill added this to the v10.10.1 milestone Nov 1, 2024
joshuaboniface pushed a commit that referenced this pull request Nov 3, 2024
Always show enabled filters

Original-merge: ed3671a

Merged-by: thornbill <[email protected]>

Backported-by: Joshua M. Boniface <[email protected]>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Nov 3, 2024
kevgrig pushed a commit to kevgrig/jellyfin-web that referenced this pull request Jan 7, 2025
Always show enabled filters

Original-merge: ed3671a

Merged-by: thornbill <[email protected]>

Backported-by: Joshua M. Boniface <[email protected]>
@viown viown deleted the always-show-hidden-filters branch January 13, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Invalid library filters cannot be removed
3 participants