Check if there are multiple parts before requesting them #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the property exists it should always be larger than 1 so the second check isn't really needed
|
Cloudflare Pages deployment
|
nvllsvm
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
I confirmed this change fixes the large amount of extraneous requests being made at the start of playback. That issue was causing me severe performance problems so I'm good with this being merged.
As a separate, future change - it might make more sense to only fetch the additional parts for the currently playing item rather than all the items at once. My guess is that playWithIntros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the property exists it should always be larger than 1 so the second check isn't really needed