Enable 'Prefer fMP4-HLS Container' by default on certain platforms #5289
Conversation
src/scripts/settings/userSettings.js
Outdated
| @@ -140,7 +140,7 @@ export class UserSettings { | |||
| return this.set('preferFmp4HlsContainer', val.toString(), false); | |||
| } | |||
|
|
|||
| return toBoolean(this.get('preferFmp4HlsContainer', false), false); | |||
| return toBoolean(this.get('preferFmp4HlsContainer', false), true); | |||
There was a problem hiding this comment.
We need to disable fMP4 in device profile on some platforms. Then we can remove this option (always enable fMP4).
At least on Tizen 4, I've never been able to get it to work - it always waits for the remuxing job to complete.
There was a problem hiding this comment.
So we disable for this version of Tizen? Or enable fMP4 by default only for HLS.js and Safari?
It is unlikely that we will test every version of Tizen and WebOS one by one. I think they should be left to the user's choice.
There was a problem hiding this comment.
We can trim
but agree
It is unlikely that we will test every version of Tizen and WebOS one by one. I think they should be left to the user's choice.
As an option, true -> !browser.tizen && !browser.web0s or list the platforms that play fMP4 for sure. In this case it will be disabled by default on some platforms, but the user can still enable it.
Tbh, I don't know why it works that way on my TV. 🤷 Iirc, I tested fMP4 with AVPlay - same bug.
There was a problem hiding this comment.
I increased the minimum version from 3 to 5 based on your experience.
-browser.tizenVersion >= 3
+browser.tizenVersion >= 5Do these older Tizen versions support MSE? If so you can enable HLS.js as a replacement.
There was a problem hiding this comment.
Tizen 4 supports HLS natively. Tizen 3 also supports it, iirc.
https://developer.samsung.com/smarttv/develop/specifications/media-specifications.html#MSE%2FEME-Specifications
There was a problem hiding this comment.
Yeah. Even Tizen 3.0 has been marked as the first version to support fMP4-HLS. Have you also tried the online m3u8 link provided by Apple? If the fMP4 in it cannot be played normally, then this should be a system issue and should be reported to Samsung.
nyanmisaka
force-pushed
the
enable-fmp4-hls-by-default
branch
from
a190904 to
e060084
Compare
fMP4 is enabled by default only on verified patforms. This largely avoids transcoding HEVC and AV1, instead letting the client handle them. Signed-off-by: nyanmisaka <[email protected]>
Signed-off-by: nyanmisaka <[email protected]>
nyanmisaka
force-pushed
the
enable-fmp4-hls-by-default
branch
from
e060084 to
6875f28
Compare
nyanmisaka
changed the title
|
Cloudflare Pages deployment
|
|
Found this for webOS support. Don't know exactly which tags we use so I am linking the site here: https://webostv.developer.lge.com/develop/specifications/streaming-protocol-drm |
|
For Tizen, this should be the relevant page: https://developer.samsung.com/smarttv/develop/specifications/general-specifications.html#Streaming-Feature-Support Sorry if I restated the obvious, found it useful to hhave the relevant links here. |
Unfortunately according to dmitrylyzo's testing, the actual behavior on older Tizen contradicts the documentation. So until someone can fully test it on every Tizen version (3.0+) and WebOS, we're not going to risk breaking playback by enabling it by default. |
thornbill
added
enhancement
|
I've been sticking to version 10.8.13 for a while because higher versions had issues with out-of-sync subtitles. After trying many things, it turns out that disabling Prefer fMP4-HLS Container on Firefox and iOS (Jellyfin Mobile) mostly solves the desync. After a lot of rewinding and fast-forwarding, desync does occur again, but that also happens on 10.8.13. However, it happens much less quickly and only occasionally. With this feature enabled by default, it almost always happens. I would like to suggest not enabling this feature by default because, in my opinion, it doesn't work well. I've already made a custom build for myself because otherwise, this version is unusable and I would be forced to revert to 10.8.13. Or maybe I'm missing something crucial? |
fMP4 is enabled by default only on verified patforms. This
largely avoids transcoding HEVC and AV1, instead letting
the client handle them.
Changes
Issues