Migrate quick connect page to react #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
added
enhancement
|
Is this just a 1 to 1 conversion or are there changes to the UI/UX? I'm asking because I've never been satisfied with the UX once a (valid) quick connect code was entered. The toast showing up in the bottom-left corner is not notable at all. |
|
Well it was a 1:1 conversion except for being able to prefill from a url parameter, but updating the ui sounds like a good idea too lol |
|
How about this? It's still not really great, but there really isn't much in the way of existing components for the stable app. 😅
|
|
Way better! |
|
Kudos, SonarCloud Quality Gate passed!
|
grafixeyehero
requested changes
Sep 17, 2023
grafixeyehero
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
InputElementto support specifying classes for the container div, call a callback function on value changes, provide an initial value, and prevent re-renders that break the webcomponentIssues
N/A