Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to upload hearing-impaired subs #4728

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

MBR-0001
Copy link
Contributor

Changes
Added a checkbox for SDH subtitles, also moved the uploading to the new sdk
image

Issues
None

Depends on: jellyfin/jellyfin#10036

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill force-pushed the subtitle-improvements-2 branch from b0756a0 to f4db19c Compare September 8, 2023 20:12
@thornbill thornbill added enhancement Improve existing functionality or small fixes accessibility Concerns the accessibility of the web client labels Sep 8, 2023
@thornbill thornbill added this to the v10.9.0 milestone Sep 8, 2023
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Sep 11, 2023
@jellyfin-bot
Copy link
Collaborator

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added merge conflict Conflicts prevent merging and removed merge conflict Conflicts prevent merging labels Sep 11, 2023
@jellyfin-bot
Copy link
Collaborator

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Sep 15, 2023
src/components/subtitleuploader/subtitleuploader.js Outdated Show resolved Hide resolved
src/strings/en-us.json Show resolved Hide resolved
@MBR-0001 MBR-0001 requested a review from thornbill September 27, 2023 14:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication

@thornbill thornbill merged commit 4109b7e into jellyfin:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Concerns the accessibility of the web client enhancement Improve existing functionality or small fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants