Add support for more remote subtitle info #4727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Server PR merged |
thornbill
force-pushed
the
subtitle-improvements-1
branch
from
8d84a67 to
8ff6bc1
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
thornbill
requested changes
Sep 12, 2023
thornbill
requested changes
Sep 14, 2023
Co-authored-by: Bill Thornton <[email protected]>
Co-authored-by: Bill Thornton <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
thornbill
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add support for new remote subtitle flags that will be added in jellyfin/jellyfin#10035
Also added
white-space:pre-lineto comment so it displays nicelyPreview:
Before:
After:
Issues
Fixes: jellyfin/jellyfin#10027
Part 2 for: jellyfin/jellyfin#10035