Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ssa/ass tags from text subtitles #4658

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

thornbill
Copy link
Member

Changes
Removes ssa/ass tags from text subtitles when normalizing the text. Similar approach has been taken in the Android TV app (jellyfin/jellyfin-androidtv#2741).

Issues
Fixes #3727

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Jun 1, 2023
@thornbill thornbill added this to the v10.9.0 milestone Jun 1, 2023
@thornbill thornbill requested a review from a team as a code owner June 1, 2023 05:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

@thornbill thornbill merged commit 639e7dc into jellyfin:master Jun 1, 2023
@thornbill thornbill deleted the no-ssa-in-srt branch June 1, 2023 17:15
@pktiuk
Copy link

pktiuk commented Mar 10, 2024

When the next release containing this patch can be expected?
I am still waiting for this fix.

@nielsvanvelzen
Copy link
Member

It will be in 10.9.

@pktiuk
Copy link

pktiuk commented Mar 10, 2024

But when can we expect this release?
This change is already waiting over half a year to be included in the release.

@nielsvanvelzen
Copy link
Member

@pktiuk
Copy link

pktiuk commented Mar 11, 2024

Thank you, these resources fully address my concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{\an8} tag support for srt files
3 participants