Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show production studio #4196

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Show production studio #4196

merged 5 commits into from
Feb 7, 2023

Conversation

mark5231
Copy link
Contributor

@mark5231 mark5231 commented Dec 9, 2022

Changes

image

Show studios. Support this feature request: https://features.jellyfin.org/posts/1203/show-production-studio-for-movies-tv-shows
Issues

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Dec 9, 2022
thornbill
thornbill requested changes Jan 5, 2023
View reviewed changes
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just one minor suggestion to simplify updating the hide class. As far as the placement goes, I think this might be better suited under the genres.

src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
@mark5231
Copy link
Contributor Author

mark5231 commented Jan 5, 2023

Looks great!

Just one minor suggestion to simplify updating the hide class. As far as the placement goes, I think this might be better suited under the genres.

Thanks for your review. I applied your suggestion. Please take a look.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nielsvanvelzen nielsvanvelzen mentioned this pull request Jan 5, 2023
Closed
@mark5231 mark5231 requested a review from thornbill January 23, 2023 04:22
thornbill
thornbill requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do prefer the general approach taken here over #4261. We will need to clean up the duplication on series pages, but that can always be done in a separate PR.

src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thornbill thornbill merged commit 44edc3d into jellyfin:master Feb 7, 2023
@1337joe 1337joe mentioned this pull request Feb 13, 2023
Merged
@thornbill thornbill mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mark5231 @thornbill