-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): Update Tauri artifacts #2130
Conversation
endrl
commented
Nov 3, 2023
- Provide better tauri artifacts
- Tauri recommends to use an older ubuntu version as this is the min version where it can actually run
Kudos, SonarCloud Quality Gate passed! |
Source for this? ubuntu-latest always points to the latest Ubuntu LTS version, so we can be sure they're always stable? See here |
Tauri links to the GNU standard library which is always forward but never backward compatible. The version you link at build time is the minimum version you need at runtime. Even AppImage which is self contained has this problem as it blacklists glibc for inclusion. For that reason Tauri Action builds with 20.04 that "most" people can run it. |
@endrl I see what you mean now. I think in that case the best course of action would be to statically link our executable, so it doesn't have any hard system dependency. What do you think about this? That way, we're not restricted at all because of the CI environment (not providing older images) and we're sure the app is universally compatible. I wonder if something along the lines of this would work. |
Tauri doesn't support *musl builds official? At least i found nothing specific about it. From jellyfin-vue view i would leave that to the tauri project as they have all the dependencies and moving parts. |
I had a look at the AppImage, it packages |
f598745
to
00c2c75
Compare
@endrl Can you check this now with the latest artifact from master? See this, it looks like it's fixed now in the default target? (so their documentation is now deprecated) I've been also playing with the cross as a runner (as suggested in that thread) and some optimizations on this branch so if the above doesn't work maybe we have more luck with cross. I've run a workflow in that branch with my latest commit so you can check it out too! Thank you very much in advance and sorry for the delay. |
The outcome of the issue is basically can't fix? tauri-apps/tauri#1355 (comment) I think github will maintain the image until the kernel is out of support, but that's just a guess. And at this point you can still fallback to cross 2.5
|
|
Cloudflare Pages deployment
|
Hello @endrl I'm sorry for letting this go waiting for so long to eventualy not even getting it merged. Although it looks like a minor thing, keeping track of yet another dependency (the ubuntu images) is an additional burden we need to handle just for the sake of people running Tauri (which I estimate are just a bunch of fulks, given it's provided in a best effort basis) + outdated systems. Additionally, I'm used to the JS way to do things, Rust (and all around Tauri really) is still mostly black magic for me, which means that there's additional burden every time something happens with it (time I could dedicate first to advance in the frontend). I really hope that in future our Tauri app could have much more love than it has now, so these kind of things are worth the effort. Even better, hopefully in future Tauri versions this is much easier (or even unnecessary to do)! |