Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MediaPlayPause listener #166

Closed
wants to merge 1 commit into from
Closed

Added MediaPlayPause listener #166

wants to merge 1 commit into from

Conversation

vov4uk
Copy link

@vov4uk vov4uk commented Jan 10, 2023

Play/Pause button will work

@dmitrylyzo
Copy link
Collaborator

dmitrylyzo commented Jan 10, 2023

IIRC, when MediaPlayPause is enabled, the OSD hint (with 5 virtual buttons: FastForward, Rewind, Previous track, Next track, Play/Pause) for Smart Remote doesn't work.

UPD:
#11 (comment)

@vov4uk
Copy link
Author

vov4uk commented Jan 10, 2023

I'm not familiar with Tizen development - but after this fix, my UE49KU6470 works correctly with my remote control

@dmitrylyzo
Copy link
Collaborator

What remote control is used?

Remote Control Samsung Smart Remote

According to the UE49KU6470 manual, its Smart Remote should show on-screen playback control when pressing Play/Pause like other models.

Samsung may require this button to work as Play/Pause to pass certification, but this is a loss of functionality, imo. At the same time, on-screen control functionality exists on the video OSD bottom panel. 🤷‍♂️

@vov4uk
Copy link
Author

vov4uk commented Jan 10, 2023

I use "Samsung Smart Remote". If you have any concerns, feel free to cancel the pull request.

@TomasMonkevic
Copy link

I can confirm that the play pause button doesn't work on the new Samsung Smart Remote. Only the middle press in the circle works

@mullerdavid
Copy link

I agree it's a loss of functionality, but personally I prefer the plain play/pause functionality. The best of both would be to implement some kind of option for it that can be set in the app.

@dmitrylyzo dmitrylyzo mentioned this pull request Feb 18, 2023
@dmitrylyzo
Copy link
Collaborator

Superseded by #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants