Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client loses focus after popup from TV #311

Closed
Lampan-git opened this issue Nov 14, 2024 · 6 comments
Closed

Client loses focus after popup from TV #311

Lampan-git opened this issue Nov 14, 2024 · 6 comments

Comments

@Lampan-git
Copy link

Bug Description
After a popup occurs from the TV when either using Quick Connect or failing to connect to a server the client loses focus. This removes the blue background from the select so you don't know what you are pressing. Input from the on-screen keyboard doesn't seem to work, though backspace does seem to work, so maybe it's just invisible when writing?

Reproduction steps

  1. a) Fail to input a valid server in the initial setup
    b) Press the Quick Connect login on the login page
  2. Press Ok on the pop up.

Current Behavior
No blue background on the selected element, so you don't know what you are going to press.
Scrolling etc in the home menu after logging in doesn't work, though pressing elements works so you could go below the screen and press something.

Expected behavior
Blue background of the current element choice, scrollable home screen etc.

Server version
10.10.1

Client Version
Jellyfin-web 10.10.1

Environment
TV: S90C
OS: OneUI/Tizen 8, v. 2013

@Jacob-077
Copy link

I'm having this exact issue. A quicker way to reproduce this is to try to delete any media, once you select cancel you'll lose control of the entire app.

@mihalyr
Copy link

mihalyr commented Nov 21, 2024

I've installed finally Jellyfin on the Samsung TV - this repo and the instructions were super helpful and made the entire thing fairly easy. But the first thing I noticed was that when trying to connect to my server and typing in the address, when I wrote the wrong address and a pop-up showed up, next thing I could not control the app with the remote anymore. I could only press back and OK on some option I could not see. So I was able to exit the app and then reopen to try it again. It happened to me several times while I figure out that simple mDNS name won't work and needed the IP, then figured I needed also the port (while on my laptop and mobile I can just use the mDNS name without port - probably a limitation of the TV).

@dantesbr
Copy link

The same here, my TV is a QN90C with Tizen 8 version 2011

@morpheus133
Copy link
Contributor

Just for helping the investigation:
On Tizen 4.0 TV I was not able to reproduce it.
Also on both emulators(including 8.0) it seems working.

@dantesbr
Copy link

Just for helping the investigation: On Tizen 4.0 TV I was not able to reproduce it. Also, on both emulators (including 8.0), it seems to be working.

Yes, the issue does not occur on the emulator, only on the TV itself.
I managed to fix it by editing the source code in jellyfin-web/src/components/confirm/confirm.js:

function useNativeConfirm() {
    // webOS seems to block modals
    // Tizen 2.x seems to block modals
    // return !browser.web0s
    //     && !(browser.tizenVersion && browser.tizenVersion < 3)
    //     && browser.tv
    //     && window.confirm;
    return false;
}

@morpheus133
Copy link
Contributor

@dantesbr will you open a PR for the correction?

dantesbr added a commit to dantesbr/jellyfin-web that referenced this issue Dec 24, 2024
… TVs with Tizen 8 (OneUI/Tizen 8). This issue only occurs on the TV itself and not on the Tizen emulator.

Fixes the issue jellyfin/jellyfin-tizen#311
dantesbr added a commit to dantesbr/jellyfin-web that referenced this issue Jan 3, 2025
… TVs with Tizen 8 (OneUI/Tizen 8). This issue only occurs on the TV itself and not on the Tizen emulator.

Fixes the issue jellyfin/jellyfin-tizen#311
dantesbr added a commit to dantesbr/jellyfin-web that referenced this issue Jan 3, 2025
… TVs with Tizen 8 (OneUI/Tizen 8). This issue only occurs on the TV itself and not on the Tizen emulator.

Fixes the issue jellyfin/jellyfin-tizen#311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants