Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add adaptive monochrome icon. #777

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Add adaptive monochrome icon. #777

merged 1 commit into from
Sep 1, 2022

Conversation

Irishsmurf
Copy link
Contributor

Android 13 supports themed app icons.
This changes adds a monochromatic icon to ic_launcher and ic_launcher_round.

  • Before:
    Screenshot_20220901-224322

  • After:
    Screenshot_20220901-224904

@Irishsmurf
Add adaptive monochrome icon.
5956343 
Android 13 supports themed app icons.
This changes adds a monochromatic icon to `ic_launcher` and `ic_launcher_round`.
Maxr1998
Maxr1998 approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok for now, but we should probably add an extra variant of the icon with better scaling later.

@Maxr1998 Maxr1998 enabled auto-merge (squash) September 1, 2022 22:38
@Maxr1998 Maxr1998 merged commit 274cbe2 into jellyfin:master Sep 1, 2022
@nielsvanvelzen nielsvanvelzen added this to the v2.5.0 milestone Sep 2, 2022
@nielsvanvelzen nielsvanvelzen mentioned this pull request Nov 22, 2022
Closed
@Maxr1998 Maxr1998 added the enhancement New feature or request label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxr1998 Maxr1998 Maxr1998 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Irishsmurf @Maxr1998 @nielsvanvelzen