-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve JS injection method #439
Improve JS injection method #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I will do some more on-device testing tomorrow and merge it if I don't find any side-effects.
I found that WebViewAssetLoader.AssetsPathHandler exists, so I removed |
69163d0
to
d334116
Compare
app/src/main/java/org/jellyfin/mobile/fragment/WebViewFragment.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Niels van Velzen <[email protected]>
d334116
to
5bcd2d6
Compare
app/src/main/java/org/jellyfin/mobile/fragment/WebViewFragment.kt
Outdated
Show resolved
Hide resolved
The main bundle is in the body too, so it makes sense to keep it like that.
app/src/main/java/org/jellyfin/mobile/fragment/WebViewFragment.kt
Outdated
Show resolved
Hide resolved
See #439 (comment) I think it is better than running a regex comparison for each request. |
No more undefined
NativeShell
Before
After