change directory structure of workflow artifacts #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
changed the title
nielsvanvelzen
added
backport
nielsvanvelzen
previously approved these changes
May 24, 2021
Maxr1998
requested changes
May 27, 2021
to please Max's OCD :P Co-authored-by: Max Rumpf <[email protected]>
|
hope ur OCD is pleased now 😜 |
|
Yes, it's good 😄 |
Maxr1998
approved these changes
May 27, 2021
nielsvanvelzen
approved these changes
May 27, 2021
once I gain som expt with one of the may options I will open a replace PR (wont promise any time-frame unless you want it gone urgently). |
|
Was just curious, we don't need it right now :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Observed with the latest release, the
version.txtfailed to be picked up during deploy.This PR should fix that alongside simplify the folder structure used to hold the build artifacts.
Note: I omitted changing the
upload-assetsaction for now until I or someone else has experience with a better alternative action.Changes
Issues