Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RedScreenOfDeath #1166

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Remove RedScreenOfDeath #1166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,6 @@ dependencies {
// Monitoring
implementation(libs.timber)
debugImplementation(libs.leakcanary)
debugImplementation(libs.redscreenofdeath.impl)
releaseImplementation(libs.redscreenofdeath.noop)

// Testing
testImplementation(libs.junit.api)
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/java/org/jellyfin/mobile/JellyfinApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package org.jellyfin.mobile

import android.app.Application
import android.webkit.WebView
import com.melegy.redscreenofdeath.RedScreenOfDeath
import org.jellyfin.mobile.app.apiModule
import org.jellyfin.mobile.app.applicationModule
import org.jellyfin.mobile.data.databaseModule
Expand All @@ -22,9 +21,6 @@ class JellyfinApplication : Application() {
Timber.plant(JellyTree())

if (BuildConfig.DEBUG) {
// Setup exception handler
RedScreenOfDeath.init(this)

// Enable WebView debugging
if (isWebViewSupported()) {
WebView.setWebContentsDebuggingEnabled(true)
Expand Down
3 changes: 0 additions & 3 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ androidx-room = "2.5.2"
# Monitoring
timber = "5.0.1"
leakcanary = "2.11"
redscreenofdeath = "0.1.3"

# Testing
junit = "5.10.0"
Expand Down Expand Up @@ -135,8 +134,6 @@ androidx-room-compiler = { group = "androidx.room", name = "room-compiler", vers
# Monitoring
timber = { group = "com.jakewharton.timber", name = "timber", version.ref = "timber" }
leakcanary = { group = "com.squareup.leakcanary", name = "leakcanary-android", version.ref = "leakcanary" }
redscreenofdeath-impl = { group = "com.mlegy.redscreenofdeath", name = "red-screen-of-death", version.ref = "redscreenofdeath" }
redscreenofdeath-noop = { group = "com.mlegy.redscreenofdeath", name = "red-screen-of-death-no-op", version.ref = "redscreenofdeath" }

# Testing
junit-api = { group = "org.junit.jupiter", name = "junit-jupiter-api", version.ref = "junit" }
Expand Down