Use Ruby 2.3 and Rubocop 0.55 #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathawks
commented
Apr 30, 2018
| @@ -2,8 +2,10 @@ | |||
|
|
|||
| module Jekyll | |||
| class PageWithoutAFile < Page | |||
| # rubocop:disable Naming/MemoizedInstanceVariableName | |||
| def read_yaml(*) | |||
There was a problem hiding this comment.
Rubocop wants to call this method @read_yaml
There was a problem hiding this comment.
The method is already called read_yaml, Rubocop wants us to name the @data instance @read_yaml no?
There was a problem hiding this comment.
Oh! Yeah, ok, that makes a lot more sense 🤦♂️
DirtyF
approved these changes
Jul 11, 2018
|
@jekyllbot: merge +dev |
|
Failing on Travis because Ruby 2.2 and GitHub Pages. 😿 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.