Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Date object from page.title to page.date #26

Merged
merged 3 commits into from
Jan 7, 2015
Merged

Conversation

alfredxing
Copy link
Member

Moves the Date object from page.title to page.date:

  • In case of a non-date archive, page.title is the name of the category or tag, and page.date is nil
  • In case of a date archive, page.title is nil and page.date is the Date object previously stored in page.title

  • Implement code
  • Add/update tests
  • Update documenation

Addresses #20.

@nitoyon
Copy link

nitoyon commented Oct 10, 2014

👍

@alfredxing
Copy link
Member Author

All done! This is technically a breaking change though. What do you think of the versioning, @parkr?

@parkr
Copy link
Member

parkr commented Oct 12, 2014

I'd say follow SemVer closely and release a 2.0! If there are any other breaking changes, they should be included in 2.0 if possible.

@alfredxing alfredxing added this to the 2.0 milestone Oct 12, 2014
@alfredxing
Copy link
Member Author

There doesn't seem to be many other issues right now. Should we release this as 2.0?

@parkr
Copy link
Member

parkr commented Nov 23, 2014

Should we release this as 2.0?

Up to you! May as well get it out there. :)

@sondr3
Copy link

sondr3 commented Jan 3, 2015

Any updates on this?

@alfredxing
Copy link
Member Author

@sondr3 Thanks for the reminder, I totally forgot about this PR!

alfredxing added a commit that referenced this pull request Jan 7, 2015
Move Date object from `page.title` to `page.date`
@alfredxing alfredxing merged commit 8633bc1 into master Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants